Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typo in load_assertion #41

Merged
merged 1 commit into from
Jan 10, 2020
Merged

fix typo in load_assertion #41

merged 1 commit into from
Jan 10, 2020

Conversation

zupzup
Copy link
Contributor

@zupzup zupzup commented Jan 9, 2020

Hey!

Very cool project, thanks for creating this!

I went through the source to get a better understanding of what's happening under the hood and stumbled over this function load_assersions in model.rs.

It seems like a minor typo of assertion to me, so I renamed it.

If it was named this way intentionally, feel free to discard this change. ☺️

@codecov
Copy link

codecov bot commented Jan 9, 2020

Codecov Report

Merging #41 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #41   +/-   ##
=======================================
  Coverage   86.94%   86.94%           
=======================================
  Files          12       12           
  Lines        1930     1930           
=======================================
  Hits         1678     1678           
  Misses        252      252
Impacted Files Coverage Δ
src/model.rs 94.87% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a630c0e...0aa85d7. Read the comment docs.

@hsluoyz
Copy link
Member

hsluoyz commented Jan 10, 2020

Thanks for your comment! The PR is great :)

@hsluoyz hsluoyz merged commit 53bfeff into casbin:master Jan 10, 2020
@zupzup zupzup deleted the master branch August 10, 2020 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants