Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some get started doc #28

Merged
merged 2 commits into from
Dec 24, 2019
Merged

Conversation

xcaptain
Copy link
Contributor

Fix #27

@codecov
Copy link

codecov bot commented Dec 23, 2019

Codecov Report

Merging #28 into master will decrease coverage by 0.21%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #28      +/-   ##
==========================================
- Coverage   85.38%   85.16%   -0.22%     
==========================================
  Files          12       12              
  Lines        1889     1861      -28     
==========================================
- Hits         1613     1585      -28     
  Misses        276      276
Impacted Files Coverage Δ
src/config.rs 83.66% <100%> (ø) ⬆️
src/management_api.rs 90.47% <100%> (-0.18%) ⬇️
src/enforcer.rs 74.52% <100%> (-0.48%) ⬇️
src/rbac_api.rs 84.49% <100%> (-0.33%) ⬇️
src/model.rs 94.54% <100%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22147ca...be7929a. Read the comment docs.

use the new_from_file api in unit-tests

So we don't need to create a model first and then
load_model from a file
@xcaptain xcaptain force-pushed the feature/add-some-doc branch from 76f38d7 to 99a3200 Compare December 24, 2019 03:50
@xcaptain
Copy link
Contributor Author

Using inline doc would be more IDE friendly like:

图片

@xcaptain xcaptain force-pushed the feature/add-some-doc branch from 99a3200 to be7929a Compare December 24, 2019 04:34
@xcaptain xcaptain mentioned this pull request Dec 24, 2019
@hsluoyz
Copy link
Member

hsluoyz commented Dec 24, 2019

lgtm

@hsluoyz hsluoyz merged commit 366c64a into casbin:master Dec 24, 2019
This was referenced Dec 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add "Installation" and "Get started" in README.
2 participants