Add multi-thread support #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ead safety added some tests to demostrate how to use casbin with multiple thread
clippy is much more strict than before
Codecov Report
@@ Coverage Diff @@
## master #26 +/- ##
==========================================
+ Coverage 84.22% 85.38% +1.15%
==========================================
Files 4 12 +8
Lines 279 1889 +1610
==========================================
+ Hits 235 1613 +1378
- Misses 44 276 +232
Continue to review full report at Codecov.
|
|
Merged. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original version uses
Rc,RefCellandHashMapwhich are not shareable between threads.This commit replaced
RcwithArc,RefCellwithRwLockand manually deal with locks withread().unwrap()andwrite().unwrap(), a simple testtest_role_api_threadsshows how to operate casbin in a thread and then sync to other threads.