Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: switch to lru #212

Merged
merged 3 commits into from
Dec 15, 2020
Merged

feat: switch to lru #212

merged 3 commits into from
Dec 15, 2020

Conversation

PsiACE
Copy link
Contributor

@PsiACE PsiACE commented Dec 14, 2020

  • async-std 1.7 -> 1.8
  • lru-cache -> lru

The switch to lru is only because it is still actively maintained.
Also, the overlap of partial dependencies may reduce compilation costs and size, albeit to a small degree.

Signed-off-by: Chojan Shang <psiace@outlook.com>
Signed-off-by: Chojan Shang <psiace@outlook.com>
Signed-off-by: Chojan Shang <psiace@outlook.com>
@codecov
Copy link

codecov bot commented Dec 14, 2020

Codecov Report

Merging #212 (73ef9aa) into master (c60e6b4) will not change coverage.
The diff coverage is 75.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #212   +/-   ##
=======================================
  Coverage   80.60%   80.60%           
=======================================
  Files          22       22           
  Lines        3429     3429           
=======================================
  Hits         2764     2764           
  Misses        665      665           
Impacted Files Coverage Δ
src/cache/default_cache.rs 97.05% <75.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8b3e21...73ef9aa. Read the comment docs.

@hsluoyz
Copy link
Member

hsluoyz commented Dec 14, 2020

@GopherJ @hackerchai

@hackerchai
Copy link
Member

lgtm

@GopherJ
Copy link
Member

GopherJ commented Dec 15, 2020

lgtm

@GopherJ GopherJ merged commit 2bcae49 into casbin:master Dec 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants