Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v2.0.0 #204

Merged
merged 37 commits into from
Aug 30, 2020
Merged

Release v2.0.0 #204

merged 37 commits into from
Aug 30, 2020

Conversation

GopherJ
Copy link
Member

@GopherJ GopherJ commented Aug 30, 2020

No description provided.

Cheng JIANG added 30 commits July 14, 2020 14:49
Signed-off-by: Cheng JIANG <jiang.cheng@vip.163.com>
Signed-off-by: Cheng JIANG <jiang.cheng@vip.163.com>
Signed-off-by: Cheng JIANG <jiang.cheng@vip.163.com>
Signed-off-by: Cheng JIANG <jiang.cheng@vip.163.com>
Signed-off-by: Cheng JIANG <jiang.cheng@vip.163.com>
Signed-off-by: Cheng JIANG <jiang.cheng@vip.163.com>
Signed-off-by: Cheng JIANG <jiang.cheng@vip.163.com>
Signed-off-by: Cheng JIANG <jiang.cheng@vip.163.com>
Signed-off-by: Cheng JIANG <jiang.cheng@vip.163.com>
Signed-off-by: Cheng JIANG <jiang.cheng@vip.163.com>
Signed-off-by: Cheng JIANG <jiang.cheng@vip.163.com>
Signed-off-by: Cheng JIANG <jiang.cheng@vip.163.com>
Signed-off-by: Cheng JIANG <jiang.cheng@vip.163.com>
…never replace it by custom cache

Signed-off-by: Cheng JIANG <jiang.cheng@vip.163.com>
…evaluated

Signed-off-by: Cheng JIANG <jiang.cheng@vip.163.com>
Signed-off-by: Cheng JIANG <jiang.cheng@vip.163.com>
Signed-off-by: Cheng JIANG <jiang.cheng@vip.163.com>
@GopherJ
Copy link
Member Author

GopherJ commented Aug 30, 2020

I see that you are not specifically checking for errors in the usage, so suggest to also include unchecked which will make calculations a bit faster.

Thanks @schungx , I've applied your advice

@codecov
Copy link

codecov bot commented Aug 30, 2020

Codecov Report

Merging #204 into master will decrease coverage by 1.83%.
The diff coverage is 76.80%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #204      +/-   ##
==========================================
- Coverage   82.56%   80.72%   -1.84%     
==========================================
  Files          21       22       +1     
  Lines        3171     3487     +316     
==========================================
+ Hits         2618     2815     +197     
- Misses        553      672     +119     
Impacted Files Coverage Δ
src/adapter/null_adapter.rs 0.00% <0.00%> (ø)
src/cached_enforcer.rs 4.16% <0.00%> (-0.30%) ⬇️
src/emitter.rs 8.57% <0.00%> (-0.52%) ⬇️
src/logger/mod.rs 0.00% <0.00%> (ø)
src/adapter/file_adapter.rs 78.06% <23.52%> (-3.15%) ⬇️
src/macros.rs 40.00% <33.33%> (-4.45%) ⬇️
src/model/assertion.rs 59.49% <36.11%> (-8.84%) ⬇️
src/adapter/memory_adapter.rs 26.85% <40.00%> (+0.11%) ⬆️
src/internal_api.rs 57.37% <40.00%> (-3.74%) ⬇️
src/convert.rs 44.11% <50.00%> (+4.11%) ⬆️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd3ca65...38accdc. Read the comment docs.

@GopherJ GopherJ merged commit 9c67ba4 into master Aug 30, 2020
@GopherJ GopherJ deleted the release-v2.0.0 branch August 30, 2020 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants