Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change Filter definition to support dynamic filter. #196

Merged
merged 1 commit into from
Jul 20, 2020
Merged

Change Filter definition to support dynamic filter. #196

merged 1 commit into from
Jul 20, 2020

Conversation

bodymindarts
Copy link
Contributor

Values of type &'static str must be known at compile time. Using a
lifetime of &'a str allows use of filter values determined at runtime.

Fixes #195

@GopherJ
Copy link
Member

GopherJ commented Jul 20, 2020

@bodymindarts Hi, I've thought about this also because it allows only static literal string which is a pain but I haven't fixed it yet. Could you fix CI?

Change Filter definition to support dynamic filter.
77e6fdd 
Values of type `&'static str` must be known at compile time. Using a
lifetime of `&'a str` allows use of filter values determined at runtime.

Signed-off-by: Justin Carter <justin@misthos.io>
@bodymindarts
Copy link
Contributor Author

I fixed he compile error - sorry I missed that (didn't test with all features).

But now there is a different issue:

nfo: installing component 'rustfmt'
36

37
  beta-x86_64-pc-windows-msvc installed - rustc 1.46.0-beta.1 (e51b714db 2020-07-15)
38

39
info: checking for self-updates
40
error: could not download file from 'https://static.rust-lang.org/rustup/release-stable.toml' to 'C:\Users\RUNNER~1\AppData\Local\Temp\rustup-updatesLnEho\release-stable.toml'
41
error: caused by: failed to make network request
42
error: caused by: error sending request for url (https://static.rust-lang.org/rustup/release-stable.toml): connection error: An existing connection was forcibly closed by the remote host. (os error 10054)
43
error: caused by: connection error: An existing connection was forcibly closed by the remote host. (os error 10054)
44
error: caused by: An existing connection was forcibly closed by the remote host. (os error 10054)
45
##[error]The process 'C:\Rust\.cargo\bin\rustup.exe' failed with exit code 1nfo: installing component 'rustfmt'
36

37
  beta-x86_64-pc-windows-msvc installed - rustc 1.46.0-beta.1 (e51b714db 2020-07-15)
38

39
info: checking for self-updates
40
error: could not download file from 'https://static.rust-lang.org/rustup/release-stable.toml' to 'C:\Users\RUNNER~1\AppData\Local\Temp\rustup-updatesLnEho\release-stable.toml'
41
error: caused by: failed to make network request
42
error: caused by: error sending request for url (https://static.rust-lang.org/rustup/release-stable.toml): connection error: An existing connection was forcibly closed by the remote host. (os error 10054)
43
error: caused by: connection error: An existing connection was forcibly closed by the remote host. (os error 10054)
44
error: caused by: An existing connection was forcibly closed by the remote host. (os error 10054)
45
##[error]The process 'C:\Rust\.cargo\bin\rustup.exe' failed with exit code 1

Looks like CI cannot download a package related to compilation on windows. Perhaps a network blip? Don't think I can fix this locally.

@GopherJ
Copy link
Member

GopherJ commented Jul 20, 2020

@bodymindarts something went wrong with github actions...I had already once this problem.

Thanks for your contributions!

@GopherJ GopherJ merged commit 808bd1e into casbin:master Jul 20, 2020
@bodymindarts bodymindarts mentioned this pull request Jul 20, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Filter should work with dynamic values (&str instead of &'static str)
2 participants
@bodymindarts @GopherJ