Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unhandled dquote #188

Merged
merged 6 commits into from
Jul 18, 2020
Merged

Fix unhandled dquote #188

merged 6 commits into from
Jul 18, 2020

Conversation

GopherJ
Copy link
Member

@GopherJ GopherJ commented Jul 18, 2020 •
edited
Loading

close: #184

fix: bump version
72fca5e 
Signed-off-by: Cheng JIANG <jiang.cheng@vip.163.com>
@codecov
Copy link

codecov bot commented Jul 18, 2020 •
edited
Loading

Codecov Report

Merging #188 into master will increase coverage by 0.24%.
The diff coverage is 73.65%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #188      +/-   ##
==========================================
+ Coverage   82.32%   82.56%   +0.24%     
==========================================
  Files          21       21              
  Lines        3111     3172      +61     
==========================================
+ Hits         2561     2619      +58     
- Misses        550      553       +3
Impacted Files Coverage Δ
src/cached_enforcer.rs 4.46% <0.00%> (ø)
src/macros.rs 44.44% <ø> (-5.56%) ⬇️
src/adapter/memory_adapter.rs 26.73% <14.28%> (-2.27%) ⬇️
src/adapter/file_adapter.rs 81.20% <89.21%> (+13.73%) ⬆️
src/enforcer.rs 87.94% <100.00%> (ø)
src/model/assertion.rs 68.33% <100.00%> (ø)
src/model/default_model.rs 95.11% <100.00%> (+0.82%) ⬆️
src/rbac/default_role_manager.rs 95.49% <100.00%> (ø)
src/rbac_api.rs 93.68% <100.00%> (-0.60%) ⬇️
src/util.rs 95.65% <100.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6851f20...0e448e6. Read the comment docs.

Cheng JIANG added 2 commits July 18, 2020 23:12
feat: remove unnessary clone
4e1df16 
Signed-off-by: Cheng JIANG <jiang.cheng@vip.163.com>
fix: handle escaped strings
b640f88 
Signed-off-by: Cheng JIANG <jiang.cheng@vip.163.com>
@GopherJ GopherJ force-pushed the fix-unhandled-dquote branch from f4a4088 to b640f88 Compare July 18, 2020 21:13
Cheng JIANG added 3 commits July 18, 2020 23:14
chore: bump version
a488894 
Signed-off-by: Cheng JIANG <jiang.cheng@vip.163.com>
fix: CI
6376122 
Signed-off-by: Cheng JIANG <jiang.cheng@vip.163.com>
fix: CI
0e448e6 
Signed-off-by: Cheng JIANG <jiang.cheng@vip.163.com>
@GopherJ GopherJ merged commit d7a88fc into casbin:master Jul 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

allowing the parsing of policy file to deal with commas inside columns
1 participant
@GopherJ