Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add workflow for benchmark. #107

Merged
merged 2 commits into from
Apr 12, 2020
Merged

Add workflow for benchmark. #107

merged 2 commits into from
Apr 12, 2020

Conversation

PsiACE
Copy link
Contributor

@PsiACE PsiACE commented Apr 12, 2020

Added support for benchmark charts, please enjoy it.

Usage:

Need a new GitHub token that can read and write repo, and add it to secrets as a PERSONAL_GITHUB_TOKEN.

May see it at https://casbin.github.io/casbin-rs/dev/bench

Example:

See Online Example -> https://psiace.me/loge/dev/bench/

FAQ

Why change force_orphan: true to keep_files: true?

  • I believe this will ensure that our document builds will never erase the benchmark history.

Credit

Expect

Close #104

@PsiACE PsiACE mentioned this pull request Apr 12, 2020
Closed
@codecov
Copy link

codecov bot commented Apr 12, 2020 •
edited
Loading

Codecov Report

Merging #107 into master will increase coverage by 7.46%.
The diff coverage is 80.65%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #107      +/-   ##
==========================================
+ Coverage   79.06%   86.52%   +7.46%     
==========================================
  Files          14       20       +6     
  Lines        2173     2858     +685     
==========================================
+ Hits         1718     2473     +755     
+ Misses        455      385      -70
Impacted Files Coverage Δ
src/adapter/mod.rs 25.00% <ø> (ø)
src/cached_enforcer.rs 6.32% <0.00%> (+6.32%) ⬆️
src/model/mod.rs 28.57% <ø> (ø)
src/adapter/memory_adapter.rs 37.17% <33.87%> (-23.94%) ⬇️
src/internal_api.rs 45.63% <40.54%> (+0.53%) ⬆️
src/model/assertion.rs 64.28% <64.28%> (ø)
src/adapter/file_adapter.rs 48.93% <75.00%> (+3.28%) ⬆️
src/model/default_model.rs 95.28% <89.01%> (ø)
src/rbac_api.rs 94.22% <91.59%> (+18.39%) ⬆️
src/config.rs 93.33% <92.85%> (+8.46%) ⬆️
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20667e0...72a053e. Read the comment docs.

@GopherJ GopherJ merged commit ff8a9fe into casbin:master Apr 12, 2020
@GopherJ GopherJ mentioned this pull request Apr 13, 2020
Closed
@PsiACE PsiACE deleted the bench-ci branch April 13, 2020 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add github-action-benchmark
2 participants
@PsiACE @GopherJ