Do not use unnecessary endian conversion.

carolynzech · Aug 11, 2024 · ec7a585 · ec7a585
1 parent 451feca
commit ec7a585
Showing 1 changed file with 4 additions and 6 deletions.
diff --git a/core/src/net/ip_addr.rs b/core/src/net/ip_addr.rs
@@ -79,9 +79,8 @@ impl Hash for Ipv4Addr {
     fn hash<H: Hasher>(&self, state: &mut H) {
         // Hashers are often more efficient at hashing a fixed-width integer
         // than a bytestring, so convert before hashing. We don't use to_bits()
-        // here as that involves a byteswap on little-endian machines, which are
-        // more common than big-endian machines.
-        u32::from_le_bytes(self.octets).hash(state);
+        // here as that may involve a byteswap which is unnecessary.
+        u32::from_ne_bytes(self.octets).hash(state);
     }
 }
 
@@ -172,9 +171,8 @@ impl Hash for Ipv6Addr {
     fn hash<H: Hasher>(&self, state: &mut H) {
         // Hashers are often more efficient at hashing a fixed-width integer
         // than a bytestring, so convert before hashing. We don't use to_bits()
-        // here as that involves byteswaps on little-endian machines, which are
-        // more common than big-endian machines.
-        u128::from_le_bytes(self.octets).hash(state);
+        // here as that may involve unnecessary byteswaps.
+        u128::from_ne_bytes(self.octets).hash(state);
     }
 }