-
Notifications
You must be signed in to change notification settings - Fork 445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use asset when available in detail card view #579
Conversation
I wonder if perhaps a better approach here would be to include an optional |
I was going to do this, but I didn't see asset in OCKAnyTask, let me look again... |
It looks like asset isn't part of |
Looking further back, it looks like the only OCKAny to have |
Co-authored-by: Erik Hornberger <51723116+erik-apple@users.noreply.github.com>
The last commit assumes |
Let me know if you want me to remove the AppIcon asset from being used for this in the sample app. I wanted to provide an example without adding additional assets. |
Great work Corey! LGTM! |
I like that this will add an example of how to use SFSymbols to the sample app! |
I was hoping to find some SF symbols to match some of the other tasks, but didn't see any other good matches. |
Thanks for the PR Corey! 🎉 |
If a card is displaying an
OCKAnyTask
it will automatically display the asset tied to the task when details are tapped. Close #524@erik-apple and @gavirawson-apple I couldn't find testcases where I should add tests for this. Let me know where to look and I can add them if needed