Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support Tooltip align prop from carbon-components v10.25 #446

Merged
merged 1 commit into from
Dec 5, 2020

Conversation

metonym
Copy link
Collaborator

@metonym metonym commented Dec 5, 2020

Closes #398

Refs: carbon-design-system/carbon#7309

Changes

  • add align prop to Tooltip
  • wrap default slot with bx--tooltip__content div
  • use optional, undocumented tooltipBodyId for tooltip content aria-describedby value
  • upgrade carbon-components to v10.25 for building pre-compiled CSS StyleSheets

Breaking Changes

  • if using SCSS from carbon-components, version >= 10.25 is required

@vercel
Copy link

vercel bot commented Dec 5, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/carbon-svelte/carbon-components-svelte/bqzuv2rrv
✅ Preview: https://carbon-components-svelte-git-tooltip-align.carbon-svelte.vercel.app

@metonym metonym merged commit 222c7f2 into master Dec 5, 2020
@metonym metonym deleted the tooltip-align branch December 5, 2020 17:05
@wolfgang-ch
Copy link

Almost perfect, I found this issue:

  • First click the start i icon
  • Then click left to the start tooltip -> a white border is displayed and the start tooltip is not closed

svelte-carbon-tooltip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tooltip has not an "align" property
2 participants