Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move rest props in DataTableSkeleton #441

Merged
merged 1 commit into from
Dec 1, 2020
Merged

Move rest props in DataTableSkeleton #441

merged 1 commit into from
Dec 1, 2020

Conversation

ispyinternet
Copy link
Contributor

move restprops from <table> to table container div to align with DataTable usage

@ispyinternet ispyinternet requested a review from metonym as a code owner December 1, 2020 17:22
@vercel
Copy link

vercel bot commented Dec 1, 2020 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/carbon-svelte/carbon-components-svelte/fw3njst0s
✅ Preview: https://carbon-components-svelte-git-datatable.carbon-svelte.vercel.app

metonym
metonym approved these changes Dec 1, 2020
View reviewed changes
Copy link
Collaborator

@metonym metonym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good – thanks!

@metonym metonym merged commit 1559d0f into carbon-design-system:master Dec 1, 2020
@ispyinternet ispyinternet deleted the datatable branch December 1, 2020 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@metonym metonym metonym approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ispyinternet @metonym