Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(TimePickerSelect): deprecate hideLabel to match spec #261

Merged
merged 2 commits into from
Sep 19, 2020
Merged

fix(TimePickerSelect): deprecate hideLabel to match spec #261

merged 2 commits into from
Sep 19, 2020

Conversation

josefaidt
Copy link
Contributor

fixes #260

Description

Adds @deprecated JSDoc syntax with message from referenced commit. Also removes hideLabel option from TimePickerSelect story

@josefaidt josefaidt requested a review from metonym September 18, 2020 20:23
@josefaidt josefaidt mentioned this pull request Sep 18, 2020
Merged
metonym
metonym approved these changes Sep 19, 2020
View reviewed changes
Copy link
Collaborator

@metonym metonym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for keeping this up to spec.

@metonym metonym merged commit f15df71 into carbon-design-system:master Sep 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@metonym metonym metonym approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[10.11]: fix(TimePickerSelect): deprecate hideLabel to match spec
2 participants
@josefaidt @metonym