Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(modal): prevent clicking inside inner modal from closing the modal #231

Merged
merged 1 commit into from
Aug 12, 2020

Conversation

metonym
Copy link
Collaborator

@metonym metonym commented Aug 12, 2020

Issue #229

Changes

To test:

  1. Open the default Modal/Composed Modal stories
  2. Click outside the modal and verify that it closes
  3. Re-open and press escape or click the "X" button; verify that it closes
  4. Re-open and click the password input "toggle password" button; verify that the modal does not close

For both the Modal/Composed Modal stories, the on:click event logs e.target to the browser console. This demonstrates that the event bubbling behavior is preserved.

- revert adding a `stopPropagation` modifier to the PasswordInput "toggle password" button
@metonym metonym merged commit 84f567a into master Aug 12, 2020
@metonym metonym deleted the fix-modal branch August 12, 2020 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant