Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: make icons slottable #1186

Merged
merged 2 commits into from
Mar 19, 2022
Merged

feat: make icons slottable #1186

merged 2 commits into from
Mar 19, 2022

Conversation

metonym
Copy link
Collaborator

@metonym metonym commented Mar 19, 2022 •
edited
Loading

Currently, icons are not slottable. Making icons slottable would support make it easier to pass custom styles and events. The workaround currently would be to create a "wrapper" component, which is rather inconvenient.

<!-- icon as prop -->
<Tag icon={Add16}>Text</Tag>

<!-- slottable icon -->
<Tag>
  Text
  <Add16 slot="icon" style="fill: red" on:click />
</Tag>

@metonym metonym merged commit e23b121 into master Mar 19, 2022
@metonym metonym deleted the slottable-icons branch March 19, 2022 18:37
@metonym
Copy link
Collaborator Author

metonym commented Mar 19, 2022

Released in v0.62.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@metonym