Remove Danger since it is no longer working reliably #2157
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Historically, we have used the
danger
gem to do some lightweight automatic PR review for this project. Mainly, danger was added to enforce a consistent format for CHANGELOG.md entries. However, we have long since moved away from a manually-maintained changelog in favor of GitHub Releases.This left danger with not much to do, other than pester PR authors about writing tests, something we already have a checklist for in our PR template (see below).
Recently, danger has stopped working altogether, due to GitHub token issues. I spent about an hour troubleshooting, to no avail.
I think it is time to retire danger from this project, since it was not providing much value, and is currently broken with no clear fix.
This PR:
Dangerfile
Short checklist
bundle exec rubocop -a
to fix linter issues?If relevant, did you create a test?