Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Danger since it is no longer working reliably #2157

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

mattbrictson
Copy link
Member

@mattbrictson mattbrictson commented Jun 6, 2024

Summary

Historically, we have used the danger gem to do some lightweight automatic PR review for this project. Mainly, danger was added to enforce a consistent format for CHANGELOG.md entries. However, we have long since moved away from a manually-maintained changelog in favor of GitHub Releases.

This left danger with not much to do, other than pester PR authors about writing tests, something we already have a checklist for in our PR template (see below).

Recently, danger has stopped working altogether, due to GitHub token issues. I spent about an hour troubleshooting, to no avail.

I think it is time to retire danger from this project, since it was not providing much value, and is currently broken with no clear fix.

This PR:

  • removes danger from the Gemfile
  • removes the Dangerfile
  • removes the danger job from our GitHub Actions workflow

Short checklist

  • Did you run bundle exec rubocop -a to fix linter issues?
  • If relevant, did you create a test?
  • Did you confirm that the RSpec tests pass?

@mattbrictson mattbrictson added the 🏠 Housekeeping Non-user facing cleanup and maintenance label Jun 6, 2024
@mattbrictson mattbrictson merged commit 4351910 into capistrano:master Jun 7, 2024
16 checks passed
@mattbrictson mattbrictson deleted the chores/remove-danger branch June 7, 2024 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏠 Housekeeping Non-user facing cleanup and maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants