storage: also allow raid devices to match install-media: true #2142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the installation media is a RAID (this is a mostly a OEM use-case),
using {"install-media": true} as a disk matcher fails to find the
expected RAID device.
This is because in the previous implementation, only Disk() objects could
have _has_in_use_partitions=True.
We now also set _has_in_use_partitions=True on involved Raid() objects.
In theory, this means that for a given RAID, the matcher can return
one Raid() object + N * Disk() objects.
In practice though, we only use disk matchers on "potential boot disks".
This should exclude from the equation Disk() objects that are part of a
Raid(). So we can reliably expect a single match.
LP: #2094966
Signed-off-by: Olivier Gayot <olivier.gayot@canonical.com>
|
cc @medicalwei |
mwhudson
approved these changes
Jan 20, 2025
dbungert
approved these changes
Jan 21, 2025
Chris-Peterson444
approved these changes
Jan 21, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the installation media is a RAID (this is a mostly a OEM use-case), using
{"install-media": true}as a disk matcher fails to find the expected RAID device.This is because in the previous implementation, only
Diskobjects could have_has_in_use_partitions=True.We now also set
_has_in_use_partitions=Trueon involvedRaidobjects.In theory, this means that for a given RAID, the matcher can return one
Raidobject + N *Diskobjects.In practice though, we only use disk matchers on "potential boot disks". This should exclude from the equation
Diskobjects that are part of aRaid. So we can reliably expect a single match.LP:#2094966