Small test cleanup for Identity and Userdata controllers #2131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By letting the UserdataController use a mocked base_app, the tests load_none, load_empty, and load_some don't actually verify the inputs and only test that the data is loaded into the model. In particular, the load_some test was loading bad cloud-config but still had a passing test. Change the base_app attribute to actually be a SubiquityModel by default. Additionally, update the load_some test to not use bad cloud-config and add a test to make sure validation errors are thrown on bad config.
ogayot
approved these changes
Jan 15, 2025
Comment on lines
+54
to
+56
| validate = ( | ||
| self.controller.app.base_model.validate_cloudconfig_schema | ||
| ) = mock.Mock() |
There was a problem hiding this comment.
The joys of automatic code formatting 🤷♂️
There was a problem hiding this comment.
I know right 🙃
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of small fixes to some test code:
base_appattribute was hiding a failing test.