Kvm test swtpm #2130
Merged
Kvm test swtpm #2130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ogayot
reviewed
Jan 15, 2025
Create a rundir variable for later configuration, defaulting to the current /tmp/kvm-test spot. Create a vmstate directory - most VM related content including disks, swtpm state, and UEFI storage lives here. Overwriting a VM does a recursive removal of vmstate.
After analyzing /etc/apparmor.d/usr.bin.swtpm, I don't see a path forward compliant with that config. So fix swtpm by making this invocation unconstrained. Given that this appears to be attack surface for VM escapes, a constrained implementation would be beneficial.
dbungert
force-pushed
the
kvm-test-swtpm
branch
from
f70ec0e to
7250779
Compare
ogayot
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several fixes to swtpm integration allowing TPMFDE test automation, including having TPM state persist across VM boots, allowing multiple VMs with TPM to run in parallel, and an apparmor integration workaround.
Sample command line