Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix stale links rename master branch to main #926

Merged
merged 2 commits into from
Jun 18, 2021
Merged

docs: fix stale links rename master branch to main #926

merged 2 commits into from
Jun 18, 2021

Conversation

blackboxsw
Copy link
Collaborator

Proposed Commit Message

Update doc references to 'main' default branch due to rename.
Also some links have eroded:
-  for doc links directly to a line num link to a
   blob/<commit>/file/path#L10 instead of blob/<branch_name>.
- pytest.param link to a specific version doc as latest has dropped
  the link

Additional Context

Test Steps

tox -e doc
open browser to doc/rtd_html/index,html

Checklist:

  • My code follows the process laid out in the documentation
  • I have updated or added any unit tests accordingly
  • I have updated or added any documentation accordingly

@TheRealFalcon
Copy link
Member

Looks like there's a couple references still left in README.md (L3) and HACKING.rst (L58, 81)

Also, are we still supporting tools/migrate-lp-user-to-github? If so, there's a few references left there too.

TheRealFalcon
TheRealFalcon approved these changes Jun 17, 2021
View reviewed changes
Copy link
Member

@TheRealFalcon TheRealFalcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved assuming we update the noted references

@blackboxsw
docs: fix stale links rename master branch to main
d1b7bd6 
Update doc references to 'main' default branch due to rename.
Also some links have eroded:
-  for doc links directly to a line num link to a
   blob/<commit>/file/path#L10 instead of blob/<branch_name>.
- pytest.param link to a specific version doc as latest has dropped
  the link
@blackboxsw blackboxsw force-pushed the doc-update-for-branch-rename branch from ff50978 to d1b7bd6 Compare June 17, 2021 20:56
@blackboxsw blackboxsw merged commit db23b1b into canonical:main Jun 18, 2021
@ubuntu-server-builder ubuntu-server-builder mentioned this pull request May 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheRealFalcon TheRealFalcon TheRealFalcon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@blackboxsw @TheRealFalcon