Move dmi functions out of util. #622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
smoser
force-pushed
the
cleanup/separate-dmi
branch
from
668c188 to
b8c8000
Compare
igalic
reviewed
Oct 23, 2020
This just separates the reading of dmi values into its own file. Some things of note: * left import of util in dmi.py only for 'is_container' It'd be good if is_container was not in util. * just the use of 'util.is_x86' to dmi.py * open() is used directly rather than load_file.
smoser
force-pushed
the
cleanup/separate-dmi
branch
from
b8c8000 to
8e7debf
Compare
OddBloke
approved these changes
Nov 2, 2020
| if syspath_value is not None: | ||
| return syspath_value | ||
|
|
||
| def is_x86(arch): |
There was a problem hiding this comment.
The one place that the util.is_x86 is now used is in DataSourceOpenStack:
cloud-init/cloudinit/sources/DataSourceOpenStack.py
Lines 226 to 227 in 0f8be87
is_x86 from util? (If not, then perhaps we could relocate is_x86 there?)
This was referenced May 12, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This just separates the reading of dmi values into its own file.
Some things of note:
It'd be good if is_container was not in util.