Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Alpine Linux support. #535

Merged
merged 19 commits into from
Aug 19, 2020
Merged

Add Alpine Linux support. #535

merged 19 commits into from
Aug 19, 2020

Conversation

dermotbradley
Copy link
Contributor

Add new module cc_apk_configure for creating Alpine /etc/apk/repositories file.
Modify cc_ca_certs, cc_ntp, cc_power_state_change, and cc_resolv_conf for Alpine.
Add Alpine template files for Chrony and Busybox NTP support.
Add Alpine template file for /etc/hosts.

@dermotbradley
Add Alpine Linux support.
cde7118 
Add new module cc_apk_configure for creating Alpine /etc/apk/repositories file.
Modify cc_ca_certs, cc_ntp, cc_power_state_change, and cc_resolv_conf for
Alpine.
Add Alpine template files for Chrony and Busybox NTP support.
Add Alpine template file for /etc/hosts.
@dermotbradley
Fix typos/syntax.
3e7d7d5
@dermotbradley
Rewrite cc_apk_configure test handler.
886fe83
@dermotbradley
Fix test_cli.py expected string as it broken when I added Alpine to
01f7b50 
cc_ntp.py's list of supported distros.
@dermotbradley
Copy link
Contributor Author

dermotbradley commented Aug 14, 2020 •
edited
Loading

Hi @OddBloke, I could do with some advice/help here with the test_handler_apk_configure.py.

Thanks to help from @raharper I fixed the test_handler.

raharper
raharper requested changes Aug 14, 2020
View reviewed changes
Copy link
Collaborator

@raharper raharper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This is a really nice PR and great addition to cloud-init.

cloudinit/config/cc_ca_certs.py Outdated Show resolved Hide resolved
tests/unittests/test_handler/test_handler_apk_configure.py Outdated Show resolved Hide resolved
cloudinit/config/cc_apk_configure.py Outdated Show resolved Hide resolved
cloudinit/config/cc_apk_configure.py Outdated Show resolved Hide resolved
cloudinit/config/cc_apk_configure.py Outdated Show resolved Hide resolved
cloudinit/config/cc_ntp.py Outdated Show resolved Hide resolved
cloudinit/config/cc_power_state_change.py Outdated Show resolved Hide resolved
cloudinit/config/cc_power_state_change.py Outdated Show resolved Hide resolved
cloudinit/config/cc_power_state_change.py Outdated Show resolved Hide resolved
cloudinit/config/cc_power_state_change.py Outdated Show resolved Hide resolved
@dermotbradley dermotbradley requested a review from raharper August 17, 2020 14:43
raharper
raharper requested changes Aug 17, 2020
View reviewed changes
Copy link
Collaborator

@raharper raharper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank for updating this PR. I've a few more bits of feedback on updating the unittests.

cloudinit/config/cc_power_state_change.py Outdated Show resolved Hide resolved
tests/unittests/test_handler/test_handler_apk_configure.py Show resolved Hide resolved
tests/unittests/test_handler/test_handler_apk_configure.py Outdated Show resolved Hide resolved
tests/unittests/test_handler/test_handler_apk_configure.py Outdated Show resolved Hide resolved
tests/unittests/test_handler/test_handler_apk_configure.py Outdated Show resolved Hide resolved
tests/unittests/test_handler/test_handler_apk_configure.py Outdated Show resolved Hide resolved
tests/unittests/test_handler/test_handler_apk_configure.py Outdated Show resolved Hide resolved
tests/unittests/test_handler/test_handler_apk_configure.py Show resolved Hide resolved
tests/unittests/test_handler/test_handler_ntp.py Outdated Show resolved Hide resolved
@dermotbradley dermotbradley requested a review from raharper August 19, 2020 02:35
raharper
raharper requested changes Aug 19, 2020
View reviewed changes
Copy link
Collaborator

@raharper raharper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is very close; just a few more spots we can clean up.

cloudinit/config/cc_apk_configure.py Outdated Show resolved Hide resolved
cloudinit/config/cc_apk_configure.py Outdated Show resolved Hide resolved
cloudinit/config/cc_apk_configure.py Outdated Show resolved Hide resolved
cloudinit/config/cc_ca_certs.py Outdated Show resolved Hide resolved
cloudinit/config/cc_ntp.py Outdated Show resolved Hide resolved
cloudinit/config/cc_power_state_change.py Outdated Show resolved Hide resolved
tests/unittests/test_handler/test_handler_ntp.py Show resolved Hide resolved
tests/unittests/test_handler/test_handler_ntp.py Show resolved Hide resolved
ad-m
ad-m reviewed Aug 19, 2020
View reviewed changes
cloudinit/config/cc_ntp.py Outdated Show resolved Hide resolved
@dermotbradley dermotbradley requested a review from raharper August 19, 2020 20:33
raharper
raharper approved these changes Aug 19, 2020
View reviewed changes
Copy link
Collaborator

@raharper raharper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@raharper raharper merged commit 79a8ce7 into canonical:master Aug 19, 2020
@OddBloke OddBloke mentioned this pull request Sep 10, 2020
Merged
@dermotbradley dermotbradley deleted the add-alpine-linux-support branch November 18, 2020 18:15
@ubuntu-server-builder ubuntu-server-builder mentioned this pull request May 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ad-m ad-m ad-m left review comments

@raharper raharper raharper approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dermotbradley @ad-m @raharper