Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add gh workflows on push to main, update status badges #4597

Merged
merged 1 commit into from
Nov 9, 2023
Merged

test: add gh workflows on push to main, update status badges #4597

merged 1 commit into from
Nov 9, 2023

Conversation

blackboxsw
Copy link
Collaborator

@blackboxsw blackboxsw commented Nov 9, 2023 •
edited
Loading

Proposed Commit Message

test: add gh workflows on push to main, update status badges

Update workflows: check_format, unit and integration to run tests each time a branch lands in main.

Update our status badges in README.md to represent the project-level status of this CI instead of per pull request.

summary: no more than 70 characters

Additional Context

Test Steps

Checklist

Merge type

  • Squash merge using "Proposed Commit Message"
  • Rebase and merge unique commits. Requires commit messages per-commit each referencing the pull request number (#<PR_NUM>)

blackboxsw added a commit to blackboxsw/cloud-init that referenced this pull request Nov 9, 2023
@blackboxsw
test: add gh workflows on push to main, update status badges (canonic…
af09b6a 
…al#4597)

Update workflows: check_format, unit and integration to run
tests each time a branch lands in main.

Update our status badges in README.md to represent the project-level
status of this CI instead of per pull request.
@blackboxsw blackboxsw force-pushed the github-workflows-on-push-main branch from a241ebb to af09b6a Compare November 9, 2023 05:08
@blackboxsw blackboxsw requested a review from holmanb November 9, 2023 05:08
@blackboxsw
test: add gh workflows on push to main, update status badges (canonic…
0c173d0 
…al#4597)

Update workflows: check_format, unit and integration to run
tests each time a branch lands in main.

Update our status badges in README.md to represent the project-level
status of this CI instead of per pull request.
@blackboxsw blackboxsw force-pushed the github-workflows-on-push-main branch from af09b6a to 0c173d0 Compare November 9, 2023 05:09
holmanb
holmanb reviewed Nov 9, 2023
View reviewed changes
Copy link
Member

@holmanb holmanb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know how to test this, but I assume it'll work? If not, we iterate.

+1 LGTM

@blackboxsw blackboxsw merged commit 3f51538 into canonical:main Nov 9, 2023
25 checks passed
@blackboxsw
Copy link
Collaborator Author

Just circling back on this post merge. success runs on the backside for actions in flight
image
And we now get the updated status banners (note "no status" on integration tests as they haven't quite finished yet).
image

@holmanb
Copy link
Member

holmanb commented Nov 10, 2023

@blackboxsw thanks for the followup, and for fixing this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holmanb holmanb holmanb approved these changes

@TheRealFalcon TheRealFalcon Awaiting requested review from TheRealFalcon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@blackboxsw @holmanb