Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add OpenCloudOS and TencentOS support #1964

Merged
merged 6 commits into from
Feb 18, 2023
Merged

add OpenCloudOS and TencentOS support #1964

merged 6 commits into from
Feb 18, 2023

Conversation

wynnfeng
Copy link
Contributor

@wynnfeng wynnfeng commented Jan 16, 2023 •
edited
Loading

Proposed Commit Message
add OpenCloudOS and TencentOS support

Checklist:

  • My code follows the process laid out in the documentation
  • I have updated or added any unit tests accordingly
  • I have updated or added any documentation accordingly

@wynnfeng wynnfeng changed the title add OpenCloudOS and TencentOS support,adjust lists to be alphabetical add OpenCloudOS and TencentOS support Jan 16, 2023
igalic
igalic reviewed Jan 17, 2023
View reviewed changes
Copy link
Collaborator

@igalic igalic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are ntp and yum_add_repo the only modules that need to be adapted?

@wynnfeng
Copy link
Contributor Author

are ntp and yum_add_repo the only modules that need to be adapted?

I added some other changes just now

holmanb
holmanb reviewed Jan 17, 2023
View reviewed changes
Copy link
Member

@holmanb holmanb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi and welcome @wynnfeng! Can you please start by signing the CLA, then adding your username to tools/.github-cla-signers?

In addition to that, if you have cloud-init logs of OpenCloudOS and TencentOS that you could attach to this initial submission, that would be much appreciated.

@wynnfeng
Copy link
Contributor Author

Hi and welcome @wynnfeng! Can you please start by signing the CLA, then adding your username to tools/.github-cla-signers?

In addition to that, if you have cloud-init logs of OpenCloudOS and TencentOS that you could attach to this initial submission, that would be much appreciated.

Thank you! I finish signing CLA，and cloud-init logs on OpenCloudOS and TencentOS will be attached after Spring Festival

@holmanb
Copy link
Member

holmanb commented Jan 18, 2023

  • verified CLA signature

Thanks, enjoy the holiday! We'll keep an eye out for the logs after the Spring Festival.

@holmanb holmanb self-assigned this Jan 18, 2023
@holmanb holmanb added the incomplete Action required by submitter label Jan 18, 2023
@wynnfeng
Copy link
Contributor Author

  • verified CLA signature

Thanks, enjoy the holiday! We'll keep an eye out for the logs after the Spring Festival.

OpencloudOS-cloud-init.log
TencentOS-cloud-init.log
Thanks,I've uploaded cloud-init logs on OpenCloudOS and TencentOS

@holmanb holmanb removed the incomplete Action required by submitter label Jan 30, 2023
holmanb
holmanb requested changes Feb 2, 2023
View reviewed changes
Copy link
Member

@holmanb holmanb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a couple of minor changes to make, but otherwise that looks mostly good.

Additionally, there are a couple of peculiar things I noticed in the logs you shared that I'd like to ask about.

  1. I see a warning log that I can't correlate to the source anywhere:
DataSourceConfigDrive.py[WARNING]: Exception Occur when append network_data: 'resolv_conf'

Is this running on a different version of cloud-init source than was submitted in this PR?

  1. The logs appear to be using the rhel distro class:
stages.py[DEBUG]: Using distro class <class 'cloudinit.distros.rhel.Distro'>

I realize that current distro implementation don't customize the RHEL distro outside of the osfamily, so this should be fine, however it would make more sense to include logs from the distro being added, I think. This can be set in /etc/cloud/cloud.cfg, note the distro key under system_info.

README.md Outdated Show resolved Hide resolved
cloudinit/config/cc_yum_add_repo.py Outdated Show resolved Hide resolved
@holmanb holmanb added the incomplete Action required by submitter label Feb 9, 2023
@holmanb
Copy link
Member

holmanb commented Feb 16, 2023

Any updates on this @wynnfeng?

@wynnfeng
Copy link
Contributor Author

Any updates on this @wynnfeng?

yes,I updates the codes, sorry I've been delayed for a few days because of something,and I've just installed the cloud-init-22.4 which I modifed on OpenCloudOS and TencentOS,so I re-upload the cloud-init logs on OpenCloudOS and TencentOS,also the cloud.cfg
but it still has DataSourceConfigDrive.py[WARNING]: Exception Occur when append network_data: 'resolv_conf' even though I install the cloud-init-22.4
OpenCloudOS-cloud-init.log
OpenCloudOS-cloud-cfg.txt
TencentOS-cloud-init.log
TencentOS-cloud-cfg.txt

@holmanb
Copy link
Member

holmanb commented Feb 17, 2023

I see that you included the changes from the recent conflict, but since this branch is still based on an old commit we still get a merge conflict.

I just resolved the issue.

@holmanb holmanb removed the incomplete Action required by submitter label Feb 17, 2023
holmanb
holmanb approved these changes Feb 18, 2023
View reviewed changes
Copy link
Member

@holmanb holmanb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@holmanb holmanb merged commit b01b5c2 into canonical:main Feb 18, 2023
@wynnfeng
Copy link
Contributor Author

I see that you included the changes from the recent conflict, but since this branch is still based on an old commit we still get a merge conflict.

I just resolved the issue.

Thank you! great!

igalic pushed a commit to igalic/cloud-init that referenced this pull request Apr 17, 2023
@wynnfeng @igalic
add OpenCloudOS and TencentOS support (canonical#1964)
ae7a36f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igalic igalic igalic left review comments

@holmanb holmanb holmanb approved these changes

Assignees

@holmanb holmanb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wynnfeng @holmanb @igalic