-
Notifications
You must be signed in to change notification settings - Fork 897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Container-Optimized OS #1748
Conversation
Hi @vteratipally, thanks for the PR! A passing comment: I don't know if you've seen this, but just for context there was some discussion related to adding support for COS, but it was dropped at that time due to broken behavior observed in the downstream images while testing. I think we'll want to make sure the concerns raised in that PR are addressed in this submission. |
Signed-off-by: varsha teratipally <teratipally@google.com>
c470c0c
to
ce9d986
Compare
Yes, I have tested whether all the modules are working or not. The modules that don't work are cc_chef,cc-growpart,cc_install_hotplug,cc_locale,cc_mcollective,cc_migrator,cc_package_update_upgrade,cc_phone_home,cc_power_state_change,cc_puppet,cc_refresh_rmc_and_interface,cc_reset_rmc |
Thanks for the response. How can we test this on an image? The test steps say "Installed cloud-init on an instance, tested manually.", but without a package manager how does one install cloud-init on an instance? I checked the docs, but after reading the "concepts" pages and the "build from open source" page, I still don't know how to test this. |
COS uses gentoo package system. COS is based on the chromium os build system where we install the package using |
Thanks for the background @vteratipally. Since we can't install this on a live image, is there some other way we can test this code on an image? |
I think we can test it on ubuntu image, as in COS(with distro: cos in system_info), we were using the ubuntu version of the cloud-init rather than the gentoo version. |
No problem, I'll poke around and see if I can make that work. Do you have sample logs ( |
sure, here it is |
@vteratipally We need all of our CI checks passing before we can merge this. Otherwise, the changes look good. |
ce9d986
to
5c29c6e
Compare
d19bad1
to
f639c97
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution!
Signed-off-by: varsha teratipally teratipally@google.com
Proposed Commit Message
Add support for Container-Optimized OS
Additional Context
Test Steps
Installed cloud-init on an instance, tested manually.
Checklist: