Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Container-Optimized OS #1748

Merged
merged 3 commits into from
Oct 20, 2022

Conversation

vteratipally
Copy link
Contributor

@vteratipally vteratipally commented Sep 22, 2022

Signed-off-by: varsha teratipally teratipally@google.com

Proposed Commit Message

Add support for Container-Optimized OS

Additional Context

Test Steps

Installed cloud-init on an instance, tested manually.

Checklist:

  • My code follows the process laid out in the documentation
  • I have updated or added any unit tests accordingly
  • I have updated or added any documentation accordingly

@holmanb
Copy link
Member

holmanb commented Sep 22, 2022

Hi @vteratipally, thanks for the PR!

A passing comment: I don't know if you've seen this, but just for context there was some discussion related to adding support for COS, but it was dropped at that time due to broken behavior observed in the downstream images while testing. I think we'll want to make sure the concerns raised in that PR are addressed in this submission.

Signed-off-by: varsha teratipally <teratipally@google.com>
@vteratipally vteratipally force-pushed the add_cos branch 3 times, most recently from c470c0c to ce9d986 Compare September 29, 2022 04:31
@vteratipally
Copy link
Contributor Author

Hi @vteratipally, thanks for the PR!

A passing comment: I don't know if you've seen this, but just for context there was some discussion related to adding support for COS, but it was dropped at that time due to broken behavior observed in the downstream images while testing. I think we'll want to make sure the concerns raised in that PR are addressed in this submission.

Yes, I have tested whether all the modules are working or not. The modules that don't work are cc_chef,cc-growpart,cc_install_hotplug,cc_locale,cc_mcollective,cc_migrator,cc_package_update_upgrade,cc_phone_home,cc_power_state_change,cc_puppet,cc_refresh_rmc_and_interface,cc_reset_rmc

@holmanb
Copy link
Member

holmanb commented Sep 29, 2022

Yes, I have tested whether all the modules are working or not. The modules that don't work are ...

Thanks for the response.

How can we test this on an image? The test steps say "Installed cloud-init on an instance, tested manually.", but without a package manager how does one install cloud-init on an instance? I checked the docs, but after reading the "concepts" pages and the "build from open source" page, I still don't know how to test this.

@vteratipally
Copy link
Contributor Author

vteratipally commented Sep 29, 2022

Yes, I have tested whether all the modules are working or not. The modules that don't work are ...

Thanks for the response.

How can we test this on an image? The test steps say "Installed cloud-init on an instance, tested manually.", but without a package manager how does one install cloud-init on an instance? I checked the docs, but after reading the "concepts" pages and the "build from open source" page, I still don't know how to test this.

COS uses gentoo package system. COS is based on the chromium os build system where we install the package using emerge cloud-init. The ebuild for cloud-init is here https://cos.googlesource.com/cos/overlays/board-overlays/+/refs/heads/master/project-lakitu/app-emulation/cloud-init/. As root filesystem is read-only in COS, we can install the cloud-init only during the build time.

@holmanb
Copy link
Member

holmanb commented Sep 29, 2022

Thanks for the background @vteratipally. Since we can't install this on a live image, is there some other way we can test this code on an image?

@vteratipally
Copy link
Contributor Author

Thanks for the background @vteratipally. Since we can't install this on a live image, is there some other way we can test this code on an image?

I think we can test it on ubuntu image, as in COS(with distro: cos in system_info), we were using the ubuntu version of the cloud-init rather than the gentoo version.

@holmanb
Copy link
Member

holmanb commented Oct 3, 2022

I think we can test it on ubuntu image, as in COS(with distro: cos in system_info), we were using the ubuntu version of the cloud-init rather than the gentoo version.

No problem, I'll poke around and see if I can make that work.

Do you have sample logs (/var/log/cloud-init.log and /var/log/cloud-init-output.log) from a booted COS? If so, that would help with review.

@vteratipally
Copy link
Contributor Author

I think we can test it on ubuntu image, as in COS(with distro: cos in system_info), we were using the ubuntu version of the cloud-init rather than the gentoo version.

No problem, I'll poke around and see if I can make that work.

Do you have sample logs (/var/log/cloud-init.log and /var/log/cloud-init-output.log) fro
cloud-init.log
cloud-init-output.log
m a booted COS? If so, that would help with review.

sure, here it is
cloud-init.log
cloud-init-output.log

@TheRealFalcon
Copy link
Member

@vteratipally We need all of our CI checks passing before we can merge this. Otherwise, the changes look good.

@vteratipally vteratipally force-pushed the add_cos branch 2 times, most recently from ce9d986 to 5c29c6e Compare October 18, 2022 17:21
@vteratipally vteratipally force-pushed the add_cos branch 7 times, most recently from d19bad1 to f639c97 Compare October 19, 2022 15:35
Copy link
Member

@holmanb holmanb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@TheRealFalcon TheRealFalcon merged commit cea875a into canonical:main Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants