Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for OpenMandriva #1520

Merged
merged 3 commits into from
Jun 17, 2022
Merged

Add support for OpenMandriva #1520

merged 3 commits into from
Jun 17, 2022

Conversation

berolinux
Copy link
Contributor

Proposed Commit Message

Add support for OpenMandriva (https://openmandriva.org/).

Signed-off-by: Bernhard Rosenkränzer <bero@lindev.ch>

Additional Context

Verified to work with an OpenMandriva Cooker image in Oracle Cloud.
Will try a few more clouds and working with extra modules; a few more patches may be necessary to make all modules work, but all the basics are looking good already with this initial patch.

Test Steps

Install OpenMandriva in a supported cloud and make sure cloud-init created the user, brought up the network, set up ssh keys, resized the filesystem, etc.

Checklist:

  • My code follows the process laid out in the documentation
  • I have updated or added any unit tests accordingly
  • I have updated or added any documentation accordingly

Conan-Kudo
Conan-Kudo suggested changes Jun 16, 2022
View reviewed changes
config/cloud.cfg.tmpl Outdated Show resolved Hide resolved
TheRealFalcon
TheRealFalcon requested changes Jun 17, 2022
View reviewed changes
Copy link
Member

@TheRealFalcon TheRealFalcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, @berolinux ! I have verified that you signed the CLA.

Overall the addition here looks good. In addition to the other comment already listed, can you also add a test to tests/unittests/test_util.py? Near all of the other OS_RELEASE_ definitions, you can add a OS_RELEASE_OPENMANDRIVA with a test to accompany it. You should be able to use other tests in the file in you need help.

@TheRealFalcon TheRealFalcon self-assigned this Jun 17, 2022
@berolinux
Add support for OpenMandriva
f70766b 
Add support for OpenMandriva (https://openmandriva.org/).
Verified to work in OCI.

Signed-off-by: Bernhard Rosenkränzer <bero@lindev.ch>
@berolinux
Copy link
Contributor Author

Should be good now (sorry, the "Compare" output is somewhat messed up because I rebased to current master while at it)

@berolinux berolinux requested a review from TheRealFalcon June 17, 2022 18:07
@TheRealFalcon
Copy link
Member

Changes look good but looks like there's some formatting and testing failures. Looks like the test is tests/unittests/test_cli.py::TestCLI::test_wb_schema_subcommand_doc_all_spot_check and there's also black failures.

@berolinux
Copy link
Contributor Author

All tests (including black) pass here now.

TheRealFalcon
TheRealFalcon approved these changes Jun 17, 2022
View reviewed changes
Copy link
Member

@TheRealFalcon TheRealFalcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@TheRealFalcon TheRealFalcon merged commit f60149d into canonical:main Jun 17, 2022
This was referenced May 12, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Conan-Kudo Conan-Kudo Conan-Kudo requested changes

@TheRealFalcon TheRealFalcon TheRealFalcon approved these changes

Assignees

@TheRealFalcon TheRealFalcon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@berolinux @TheRealFalcon @Conan-Kudo