Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add miraclelinux support #1128

Merged
merged 1 commit into from
Dec 7, 2021
Merged

Add miraclelinux support #1128

merged 1 commit into from
Dec 7, 2021

Conversation

tSU-RooT
Copy link
Contributor

@tSU-RooT tSU-RooT commented Dec 2, 2021

Proposed Commit Message

Add miraclelinux support

Additional Context

https://www.cybertrust.co.jp/miracle-linux/
Install ISO is available from here: https://repo.dist.miraclelinux.net/miraclelinux/isos/8.4-released/x86_64/

Test Steps

tox

_____________________________________________________________ summary _____________________________________________________________
  py3: commands succeeded
  xenial-dev: commands succeeded
  flake8: commands succeeded
  pylint: commands succeeded
  congratulations :)

Checklist:

  • My code follows the process laid out in the documentation
  • I have updated or added any unit tests accordingly
  • I have updated or added any documentation accordingly

holmanb
holmanb approved these changes Dec 2, 2021
View reviewed changes
Copy link
Member

@holmanb holmanb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @tSU-RooT. This looks good to me.

TheRealFalcon
TheRealFalcon requested changes Dec 6, 2021
View reviewed changes
Copy link
Member

@TheRealFalcon TheRealFalcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tSU-RooT . This PR looks good.

Before we can merge, you'll need to perform a rebase. There's a merge conflict due to cloudinit/tests/test_util.py being moved to tests/unittests/test_util.py , so your changes will have to be moved there as well.

@tSU-RooT
Copy link
Contributor Author

tSU-RooT commented Dec 7, 2021

Thanks for reviews, I will rebase my changes.

@tSU-RooT tSU-RooT force-pushed the add-miraclelinux-support branch from 5031ab3 to 6fa40df Compare December 7, 2021 05:06
TheRealFalcon
TheRealFalcon approved these changes Dec 7, 2021
View reviewed changes
Copy link
Member

@TheRealFalcon TheRealFalcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@TheRealFalcon TheRealFalcon merged commit 0ed00ad into canonical:main Dec 7, 2021
@ubuntu-server-builder ubuntu-server-builder mentioned this pull request May 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holmanb holmanb holmanb approved these changes

@TheRealFalcon TheRealFalcon TheRealFalcon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tSU-RooT @TheRealFalcon @holmanb