Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mono-repoize Calyx LSP + Tree-sitter #1922

Merged
merged 19 commits into from
Feb 29, 2024
Merged

Mono-repoize Calyx LSP + Tree-sitter #1922

merged 19 commits into from
Feb 29, 2024

Conversation

sgpthomas
Copy link
Collaborator

@sgpthomas sgpthomas commented Feb 16, 2024

I've decided that this is at a point where it makes sense to merge the LSP stuff into the main Calyx mono-repo. It makes dealing with using the Calyx lib for diagnostics easier.


[dependencies.tokio]
version = "1"
features = ["io-util", "io-std", "macros", "rt-multi-thread", "net"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Multi-threading! In 2024!!

@rachitnigam
Copy link
Contributor

Looks awesome! I will ask you to document things to your discretion so we can fix breakages when they happen. It might be good to provide a high-level overview in the docs/ as well for people trying to build upon it. This will also make it easier for @EclecticGriffin and co to integrate the cider-dap stuff they've been working on for a nice, out-of-the-box VS Code extension

@sgpthomas sgpthomas marked this pull request as ready for review February 23, 2024 16:03
@sgpthomas
Copy link
Collaborator Author

I think that this is at a point where it's ready to review / merge into main. I've setup package publishing for the VSCode extension so that it's installable from the VSCode store. In the future it would be nice if it good automatically install the calyx-lsp. How does the Cargo package publishing stuff work? Is there anything special that I need to do to get calyx-lsp published on crates.io?

@sampsyo
Copy link
Contributor

sampsyo commented Feb 27, 2024

AMAZING. I looked things over briefly and I think everything's good to go!

I don't know much about the crates.io publishing; I imagine that @rachitnigam just manually types cargo publish? It would of course be cool to someday set up an action to do this automatically when stuff is tagged (or maybe I misremember and we already have that). But that can of course happen separately!

@rachitnigam
Copy link
Contributor

Indeed! I just manually push these crates to cargo but it is high time for us to automate this process because it's blocking us from producing new releases quickly.

@rachitnigam
Copy link
Contributor

I'm enabling auto-merge to we can prepare this for the release.

@rachitnigam rachitnigam enabled auto-merge (squash) February 29, 2024 13:54
@rachitnigam
Copy link
Contributor

Also, should we archive the calyx-lsp repo after merging this?

@rachitnigam rachitnigam merged commit 718b939 into main Feb 29, 2024
7 checks passed
@rachitnigam rachitnigam deleted the calyx-lsp branch February 29, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants