Deprecate @static
#1897
Merged
Deprecate @static
#1897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think you should forge ahead with the changes to the frontends. The one thing to figure out is whether all the frontends should be emitting promotable or static? |
|
I think they should all emit |
This was referenced Feb 12, 2024
rachitnigam
pushed a commit
that referenced
this pull request
Feb 16, 2024
* replace static w// interval * change primitives to @interval * modified tests * promte_static -> promotable * get rid of static * remove attribute_promotion * py frontend uses promotable * rewrite exp tests * corrected some tests * overwrite tests * overwrite failing tests * change interface * add tests * add well formed check * change compile_invoke * add tests * compile invoke test * change iterface * adjustments * fix borrow error * clippy * move files * fix test * rewrite mlir test * always promote @interval * interp tests * documentation * dummy change * static->interval * update tests * add documentation to compile-static-interface * well formed check' * small change * done * tests * rewrite test * dummy change * github workflow * docker file checks out main * checkout master * checkout specific version * go back to og dockerfile * checkout specific commit * does this work * still not working * dummy change so non-merge commit * chatgpt no cache * does this change things * modify relay tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Roughly follows the plan outlined in #1896. I'm going to wait to merge for two reasons.
@staticand what to replace it with #1896.@staticto use other attributes. This may require some coordination with CIRCT (although I'm not 100% sure?). That's why one of the compiler tests is failing.(Edit)
This also deletes the
compile-emptyandattribute-promotionpasses, both of which are no longer necessary.I have made this PR in the Dahlia repo (cucapra/dahlia#415) that will fix the last non-passing test case. Seems like we don't need to make any changes to CIRCT, since it doesn't use the
@staticattribute anymore.This Issue (#1896) goes more in-depth about what each attribute means now... I can also update the docs in a subsequent PR.