Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register options for cell-share #1826

Merged
merged 2 commits into from
Dec 26, 2023
Merged

Register options for cell-share #1826

merged 2 commits into from
Dec 26, 2023

Conversation

rachitnigam
Copy link
Contributor

Makes cell-share new the options API (#1814).

// 3) whether to print the par timing map. For exampe, if "-x cell-share:print_par_timing"
///4) whether to run sharing with Calyx 2020 settings: no component sharing,
/// only share registers/combinational components (e.g., "-x cell-share:calyx_2020")
/// 5) whether to share across static par threads (e.g., "-x cell-share:share_static_par")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@calebmkim it seems that this option is not actually used (or even parsed) in this function. Is that expected?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah you're right. It just always shares across static pars now. (I think this was from an earlier version of the pass and I forgot to change the documentation).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, any point adding this option back?

* New opts interface for `static-promotion`

* update tests
@rachitnigam rachitnigam merged commit 7170cca into main Dec 26, 2023
7 checks passed
@rachitnigam rachitnigam deleted the cell-share-opts branch December 26, 2023 21:08
rachitnigam added a commit that referenced this pull request Feb 16, 2024
* register opts for cell-share

* New opts interface for `static-promotion` (#1827)

* New opts interface for `static-promotion`

* update tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants