Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Support user-defined platforms when serving #734

Merged
merged 1 commit into from
May 6, 2020
Merged

fix: Support user-defined platforms when serving #734

merged 1 commit into from
May 6, 2020

Conversation

statm
Copy link
Contributor

@statm statm commented May 6, 2020

Summary

#729 breaks react-native-windows projects, as it omits platforms other than ios and android:

done ▶︎ Packager server running on http://localhost:8081
info ▶︎ Chrome Remote debugger connected
info ▶︎ GET /launch-js-devtools 200
info ▶︎ React Native debugger client connected
info ▶︎ Compiling bundle "index" for platform windows
error ▶︎ Debug: internal, implementation, error
TypeError: Cannot read property 'alreadySet' of undefined
at isUserChangedAlreadySetBundleOptions
(D:\playground\HaulRepro\node_modules\@haul-bundler\core\build\server\setupCompilerRoutes.js:191:23)
at handler (D:\playground\HaulRepro\node_modules\@haul-bundler\core\build\server\setupCompilerRoutes.js:93:38)
at module.exports.internals.Manager.execute (D:\playground\HaulRepro\node_modules\@hapi\hapi\lib\toolkit.js:41:33)
at Object.internals.handler (D:\playground\HaulRepro\node_modules\@hapi\hapi\lib\handler.js:46:48)
at exports.execute (D:\playground\HaulRepro\node_modules\@hapi\hapi\lib\handler.js:31:36)
at Request._lifecycle (D:\playground\HaulRepro\node_modules\@hapi\hapi\lib\request.js:312:68)
at processTicksAndRejections (internal/process/task_queues.js:93:5)
at async Request._execute (D:\playground\HaulRepro\node_modules\@hapi\hapi\lib\request.js:221:9)
error ▶︎ GET /index.bundle 500

This PR initializes bundleOptions properly with all platforms provided.

Test plan

@statm statm changed the title Support user-defined platforms fix: Support user-defined platforms when serving May 6, 2020
@zamotany zamotany merged commit 4630a1d into callstack:master May 6, 2020
@zamotany
Copy link
Contributor

zamotany commented May 6, 2020

Thanks for the PR! 👏

@statm statm mentioned this pull request May 11, 2020
Merged
@statm statm deleted the plat-fix branch May 18, 2020 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zamotany zamotany zamotany approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@statm @zamotany