Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: React Native Windows E2E test app #726

Merged
merged 54 commits into from
May 14, 2020
Merged

fix: React Native Windows E2E test app #726

merged 54 commits into from
May 14, 2020

Conversation

statm
Copy link
Contributor

@statm statm commented Apr 21, 2020 •
edited
Loading

Summary

Fix the React Native Windows E2E test app that has been failing ADO CI check callstack.haul:

  • Re-create E2E app with react-native-windows 0.61, following the guide here.
  • Add a task to install VS component Microsoft.VisualStudio.ComponentGroup.UWP.VC.v141, which does not come with the build agent. (This task takes 15~20 minutes, which is not ideal. Hopefully it'll be addressed in the next RNW version.)
  • Tweak the test code to give appium longer time (4 sec -> 20 sec) for startup.

Potential future work: test with 'haul start' instead of 'haul bundle' to catch regressions like #734.

Test plan

@statm statm marked this pull request as draft April 21, 2020 22:31
@statm statm closed this May 8, 2020
@statm statm reopened this May 8, 2020
@statm statm closed this May 11, 2020
@statm statm reopened this May 11, 2020
@statm statm marked this pull request as ready for review May 11, 2020 18:13
@statm
Copy link
Contributor Author

statm commented May 12, 2020

cc @zamotany I think this is ready for merge 😄

zamotany
zamotany reviewed May 12, 2020
View reviewed changes
Copy link
Contributor

@zamotany zamotany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work. Really appreciate the effort 🎉💪👍 I'll have deeper look tomorrow.

fixtures/react_native_windows_e2e_app/babel.config.js Outdated Show resolved Hide resolved
@thymikee
Copy link
Member

Lovely contribution <3

@zamotany zamotany merged commit c0bfea7 into callstack:master May 14, 2020
@zamotany
Copy link
Contributor

Thanks again for the work @statm 💯 👍

@zamotany zamotany mentioned this pull request May 14, 2020
Closed
@statm statm deleted the ado-fix branch May 14, 2020 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zamotany zamotany zamotany left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@statm @thymikee @zamotany