Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix up return types, better asserts and PHP74 #709

Merged
merged 2 commits into from
Nov 4, 2019
Merged

Fix up return types, better asserts and PHP74 #709

merged 2 commits into from
Nov 4, 2019

Conversation

dereuromark
Copy link
Member

refs #708

@dereuromark dereuromark added this to the 3.x milestone Nov 4, 2019
@dereuromark
Copy link
Member Author

I set php74 to allow failure for now

There was 1 failure:
1) DebugKit\Test\TestCase\Panel\VariablesPanelTest::testShutdown
Failed asserting that 'Unserializable object - stdClass. Error: Serialization of 'PDO' is not allowed in /home/travis/build/cakephp/debug_kit/src/Panel/VariablesPanel.php, line 168' starts with "Unserializable object - stdClass. Error: You cannot serialize or unserialize PDO instances".
/home/travis/build/cakephp/debug_kit/tests/TestCase/Panel/VariablesPanelTest.php:112

Those issues can be resolved in a follow up PR.

@saeideng saeideng merged commit 1796aa7 into master Nov 4, 2019
@saeideng saeideng deleted the bugfix/returntype branch November 4, 2019 14:34
@garas
Copy link
Member

garas commented Nov 4, 2019

PDO error is just different exception class with different message.

7.4: Exception: Serialization of 'PDO' is not allowed.

5.0 - 7.3: PDOException: You cannot serialize or unserialize PDO instances

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
3.x
Development

Successfully merging this pull request may close these issues.
3 participants
@dereuromark @garas @saeideng