run VACUUM command to free disc space #702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garas
reviewed
Oct 8, 2019
davalb
force-pushed
the
vacuum
branch
2 times, most recently
from
653f8dc to
2ef2c3b
Compare
|
Wait a sec, I just had the thought, what if somebody doesn't use sqllite? the VACUUM command might lead to an error in other database-engines. I believe I need to check what database-engine is used, before runnign VACUUM. Sorry for the trouble |
markstory
reviewed
Oct 8, 2019
src/Model/Table/RequestsTable.php
Outdated
| @@ -108,5 +108,10 @@ public function gc() | |||
|
|
|||
| $statement = $query->execute(); | |||
| $statement->closeCursor(); | |||
|
|
|||
| $conn = $this->getConnection(); | |||
| if (is_a($conn->getDriver(), 'Cake\Database\Driver\Sqlite')) { | |||
There was a problem hiding this comment.
We generally use instanceof instead of is_a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the size of
debug_kit.sqlitewill keep growing even though theRequestsTablehas a garbage collection implemented.After some research (https://stackoverflow.com/questions/35787220/sqlite-file-size-not-decreasing-after-deleting-some-rows-from-database-in-ios and https://sqlite.org/lang_vacuum.html) I found out that disc space is not automatically freed. It is only freed if the database is recreated with the VACUUM; command.