Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add basic dashboard. #593

Merged
merged 11 commits into from
Nov 10, 2019
Merged

Add basic dashboard. #593

merged 11 commits into from
Nov 10, 2019

Conversation

dereuromark
Copy link
Member

First two points of #554

This can probably be improved in steps.

@dereuromark dereuromark added this to the 3.x milestone Mar 2, 2018
@markstory
Copy link
Member

Where this be attached to the toolbar at all?

@dereuromark
Copy link
Member Author

dereuromark commented Mar 3, 2018 •
edited
Loading

I didnt yet, but we can.
I mainly thought people could link this in their admin backend (as I always do) where needed.
But it seems useful to also have a button in the toolbar.
And then even move "global" things into there instead of having so many tabs at the bottom?

@markstory
Copy link
Member

And then even move "global" things into there instead of having so many tabs at the bottom?

That could work. The toolbar should have all the information for the current request, but cache clearing, database reset, and other visualizations could live in a dashboard.

@lorenzo
Copy link
Member

lorenzo commented Mar 4, 2018

Do you mind attaching a screenshot of this dashboard?

@ADmad
Copy link
Member

ADmad commented Aug 9, 2019

@dereuromark Ping

@dereuromark
Copy link
Member Author

Is someone interested in finishing this up?
As I mentioned this would be an incremental thing probably.

@codecov
Copy link

codecov bot commented Nov 4, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@5de7f3b). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #593   +/-   ##
=========================================
  Coverage          ?   50.52%           
  Complexity        ?      480           
=========================================
  Files             ?       48           
  Lines             ?     1429           
  Branches          ?        0           
=========================================
  Hits              ?      722           
  Misses            ?      707           
  Partials          ?        0
Impacted Files Coverage Δ Complexity Δ
src/Controller/DebugKitController.php 0% <0%> (ø) 8 <8> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5de7f3b...8fed506. Read the comment docs.

@dereuromark
Copy link
Member Author

debugKit

here you go.
I think for a first iteration this is probably fair enough.

markstory
markstory reviewed Nov 5, 2019
View reviewed changes
config/routes.php Outdated Show resolved Hide resolved
markstory
markstory reviewed Nov 6, 2019
View reviewed changes
src/Controller/DebugKitController.php Outdated Show resolved Hide resolved
src/Controller/DebugKitController.php Outdated Show resolved Hide resolved
markstory and others added 7 commits November 8, 2019 14:44
@dereuromark
Copy link
Member Author

Syntax error or access violation: 1235 This version of MySQL doesn't yet support 'LIMIT & IN/ALL/ANY/SOME subquery'

@markstory markstory merged commit 74c289c into master Nov 10, 2019
@dereuromark dereuromark deleted the master-dashboard branch November 10, 2019 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stickler-ci stickler-ci stickler-ci left review comments

@markstory markstory markstory left review comments

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
3.x
Development

Successfully merging this pull request may close these issues.
5 participants
@dereuromark @markstory @lorenzo @ADmad @stickler-ci