Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to skip legacy generics #359

Merged
merged 1 commit into from
May 21, 2022
Merged

Add option to skip legacy generics #359

merged 1 commit into from
May 21, 2022

Conversation

othercorey
Copy link
Member

@othercorey othercorey commented May 21, 2022 •
edited
Loading

Closes #347

Cannot add test case because codesniffer doesn't support setting properties for tests.

@othercorey othercorey force-pushed the object-arrays branch 2 times, most recently from aa56826 to 00a71bc Compare May 21, 2022 10:03
@othercorey othercorey marked this pull request as ready for review May 21, 2022 10:03
@othercorey othercorey requested a review from dereuromark May 21, 2022 10:03
dereuromark
dereuromark approved these changes May 21, 2022
View reviewed changes
Copy link
Member

@dereuromark dereuromark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesnt hurt to have the option.

@othercorey othercorey merged commit 4bca0b8 into 5.x May 21, 2022
@othercorey othercorey deleted the object-arrays branch May 21, 2022 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dereuromark dereuromark dereuromark approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@othercorey @dereuromark