This repository has been archived by the owner on Apr 6, 2021. It is now read-only.
fixed console resizing bug #522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
When resizing console, maximizing it, then minimizing it again, the draggable bar is no longer at the correct height so trying to resize the console by dragging the bar no longer works. (See the gif below!) This happens because
container.heightbecomes a string that represents the percentage height (e.g.,"50%") and laterMath.maxis called with an integer and that string, returningNaNto which the container's height is incorrectly set.Description of changes:
This PR uses the container's
offsetHeightinstead.cc @danallan @nightwing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.