Add missing inline to fix multiple definition error #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also add a separate dummy translation unit to the tests to ensure this doesn't happen again.
c42f
force-pushed
the
cjf/fix-multiple-defs
branch
from
7bc3171 to
89530f2
Compare
|
Looks good to me. Good idea with the test too. |
bbannier
added a commit
to zeek/spicy
that referenced
this pull request
Nov 16, 2020
This patch bumps tinyformat to a version containing the upstream fix for c42f/tinyformat#76 (and the follow up fix c42f/tinyformat#80). We also add a regression test. Closes #571.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also add a separate dummy translation unit to the tests to ensure this
doesn't happen again.
Fixes #79