Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support runscript callbackHeader #1787

Merged
merged 1 commit into from
Jun 8, 2022
Merged

Support runscript callbackHeader #1787

merged 1 commit into from
Jun 8, 2022

Conversation

hellozepp
Copy link
Contributor

@hellozepp hellozepp commented May 30, 2022 •
edited
Loading

问题描述

我在使用异步执行run/script接口时，发现callback不支持设置header，而这个header在我的业务中是一个必要操作，否则会导致callback请求失败。

代码实例

添加了一个可选参数callbackHeader，使用方式如下：

params.put("callback", config.getNotebookUrl() + "/api/job/callback");
params.put("async", "true");
params.put("callbackHeader", "{\"Authorization\":\"Bear xxxxx\"}");

@hellozepp
Copy link
Contributor Author

@allwefantasy PTAL

@allwefantasy allwefantasy merged commit e56aaaf into byzer-org:master Jun 8, 2022
allwefantasy added a commit that referenced this pull request Jun 8, 2022
@allwefantasy
Revert "Support runscript callbackHeader (#1787)"
5df771f 
This reverts commit e56aaaf.
@allwefantasy allwefantasy mentioned this pull request Jun 8, 2022
Merged
allwefantasy added a commit that referenced this pull request Jun 8, 2022
@allwefantasy
Revert "Support runscript callbackHeader (#1787)" (#1789)
445b081 
This reverts commit e56aaaf.
@hellozepp hellozepp mentioned this pull request Jul 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allwefantasy allwefantasy allwefantasy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hellozepp @allwefantasy