Clear stack map data structures upon FunctionBuilderContext reuse
#8962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were previously failing to clear `self.stack_map_vars` and `self.stack_map_values`. Clearing `self.dfs` is not strictly necessary, since calling `self.dfs.iter()` internally clears its internal data before iteration begins, but its nice to tidy up anyways. Additionally, match on all the fields of `self` so that if we add more, we get compiler errors to remind us to clear the new fields as well.
elliottt
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were previously failing to clear
self.stack_map_varsandself.stack_map_values. Clearingself.dfsis not strictly necessary, since callingself.dfs.iter()internally clears its internal data before iteration begins, but its nice to tidy up anyways. Additionally, match on all the fields ofselfso that if we add more, we get compiler errors to remind us to clear the new fields as well.