Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix clippy::doc_lazy_continuation lints. #8952

Merged
merged 1 commit into from
Jul 15, 2024
Merged

Fix clippy::doc_lazy_continuation lints. #8952

merged 1 commit into from
Jul 15, 2024

Conversation

waywardmonkeys
Copy link
Contributor

These make it easier to read ordered and unordered lists by having more consistent indentation.

@waywardmonkeys
Fix clippy::doc_lazy_continuation lints.
1c6138a 
These make it easier to read ordered and unordered lists by
having more consistent indentation.
@waywardmonkeys waywardmonkeys requested a review from a team as a code owner July 13, 2024 10:40
@waywardmonkeys waywardmonkeys requested review from fitzgen and removed request for a team July 13, 2024 10:40
@github-actions github-actions bot added the wasi Issues pertaining to WASI label Jul 13, 2024
alexcrichton
alexcrichton approved these changes Jul 15, 2024
View reviewed changes
Copy link
Member

@alexcrichton alexcrichton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@alexcrichton alexcrichton added this pull request to the merge queue Jul 15, 2024
Merged via the queue into bytecodealliance:main with commit 91e059d Jul 15, 2024
37 checks passed
@alexcrichton
Copy link
Member

Also, if you're interested, we default allow all clippy lints in this workspace because it's found to be too noisy by default. These warnings showed up due to a misconfiguration issue. If you'd like though selectively adding lints to that [workspace.lints.clippy] block is something that's reasonable to do on a one-off basis. For example adding this lint to that block sounds like a good idea, although I think it will need to wait a bit because this lint was added in Rust 1.80 and we're using 1.79 in CI.

@waywardmonkeys waywardmonkeys deleted the fix-doc-lazy-continuation-lints branch July 15, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexcrichton alexcrichton alexcrichton approved these changes

@fitzgen fitzgen Awaiting requested review from fitzgen fitzgen is a code owner automatically assigned from bytecodealliance/wasmtime-core-reviewers

Assignees
No one assigned
Labels
wasi Issues pertaining to WASI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@waywardmonkeys @alexcrichton