Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix file-per-thread logging in other threads #7422

Merged
merged 1 commit into from
Oct 31, 2023
Merged

Fix file-per-thread logging in other threads #7422

merged 1 commit into from
Oct 31, 2023

Conversation

alexcrichton
Copy link
Member

This commit fixes logging under -D log-to-files mode to not panic when logging happens in WASI-spawned thread which won't have initialization for the logger invoked already.

Closes #7418

@alexcrichton
Fix file-per-thread logging in other threads
565e25c 
This commit fixes logging under `-D log-to-files` mode to not panic when
logging happens in WASI-spawned thread which won't have initialization
for the logger invoked already.

Closes bytecodealliance#7418
@alexcrichton alexcrichton requested a review from a team as a code owner October 31, 2023 16:00
@alexcrichton alexcrichton requested review from fitzgen and removed request for a team October 31, 2023 16:00
@fitzgen fitzgen enabled auto-merge October 31, 2023 16:16
@fitzgen fitzgen added this pull request to the merge queue Oct 31, 2023
Merged via the queue into bytecodealliance:main with commit afa1dfa Oct 31, 2023
@alexcrichton alexcrichton deleted the fix-file-per-thread-logger-panic branch October 31, 2023 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fitzgen fitzgen fitzgen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

wasmtime panic when using log-to-files with specific wasm file
2 participants
@alexcrichton @fitzgen