Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mpk: turn on memory_protection_keys during fuzzing #7393

Merged
merged 1 commit into from
Oct 28, 2023
Merged

mpk: turn on memory_protection_keys during fuzzing #7393

merged 1 commit into from
Oct 28, 2023

Conversation

abrown
Copy link
Contributor

@abrown abrown commented Oct 27, 2023

This also twists the max_memory_protection_keys knob.

@abrown
mpk: turn on memory_protection_keys during fuzzing
5dc12eb 
This also twists the `max_memory_protection_keys` knob.
@abrown abrown requested a review from a team as a code owner October 27, 2023 21:28
@abrown abrown requested review from alexcrichton and removed request for a team October 27, 2023 21:28
@abrown
Copy link
Contributor Author

abrown commented Oct 27, 2023

I've been running some fuzzing locally with this and it seems OK:

  • currently at #227829 of cargo +nighly fuzz run instantiate
  • currently at #160974 of cargo +nighly fuzz run spectests
  • I had trouble running the differential target, though: I ran into build issues with the wasm-spec-interpreter and, with that disabled, I observed a segfault from V8. Has anyone else run this target recently?

This PR never really force-enables the MPK feature: it is only ever set to auto, so if the machine doing the fuzzing does not have MPK enabled, this feature won't really get tested.

@github-actions github-actions bot added the fuzzing Issues related to our fuzzing infrastructure label Oct 27, 2023
@github-actions
Copy link

Subscribe to Label Action

cc @fitzgen

This issue or pull request has been labeled: "fuzzing"

Thus the following users have been cc'd because of the following labels:

  • fitzgen: fuzzing

To subscribe or unsubscribe from this label, edit the .github/subscribe-to-label.json configuration file.

Learn more.

alexcrichton
alexcrichton approved these changes Oct 27, 2023
View reviewed changes
Copy link
Member

@alexcrichton alexcrichton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unsure what's going on with v8, but are you sure it's not related to mpk?

Otherwise looks good to me and let's see what oss-fuzz says

@alexcrichton alexcrichton added this pull request to the merge queue Oct 27, 2023
Merged via the queue into bytecodealliance:main with commit ecd3747 Oct 28, 2023
@abrown abrown deleted the pku-fuzzing-enable branch October 28, 2023 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexcrichton alexcrichton alexcrichton approved these changes

Assignees
No one assigned
Labels
fuzzing Issues related to our fuzzing infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abrown @alexcrichton