This repository has been archived by the owner on Dec 8, 2022. It is now read-only.
New provider Person #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add tests for coverage up
add new type and new file for credit cart
and add helpers function, which check slice string type to has element
done concept
update fork
add TitleMale
Codecov Report
@@ Coverage Diff @@
## master #12 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 5 8 +3
Lines 289 380 +91
=====================================
+ Hits 289 380 +91
Continue to review full report at Codecov.
|
|
Wow. Would you mind update the Readme too, about this new feature?
|
|
Yes , a little later |
bxcodec
suggested changes
Oct 29, 2017
lorem_test.go
Outdated
| package faker | ||
|
|
||
| import ( | ||
| "github.com/agoalofalife/faker/support/slice" |
There was a problem hiding this comment.
sorry, but change this to bxcodec
There was a problem hiding this comment.
@bxcodec done
bxcodec
approved these changes
Oct 29, 2017
|
@agoalofalife LGTM |
|
Who will merge? |
|
When I've approved it, you can merge it directly. :) |
|
good |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new provider Person