Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iOS fixes #304

Merged
merged 2 commits into from
Nov 3, 2021
Merged

iOS fixes #304

merged 2 commits into from
Nov 3, 2021

Conversation

thomassth
Copy link
Contributor

@thomassth thomassth commented May 11, 2021 •
edited
Loading

#302 but in a separate branch. See if this is better.

@nickrandolph
Copy link
Contributor

I think since we merged the timezone pr that there's now conflicts on this PR that are preventing a merge:
Conflicting files
example/ios/.symlinks/plugins/device_calendar
example/lib/presentation/pages/calendars.dart

@andzejsw
Copy link
Contributor

andzejsw commented May 12, 2021 •
edited
Loading

In my opinion no generated files should be commited and should be added to ".gitignore". Since "ios/.symlinks" folder is generated, it with all of its content should be gitignored. Do you agree guys?

@thomassth
Copy link
Contributor Author

i've added it into .gitignore and caught up with upstream.

@thomassth thomassth mentioned this pull request May 12, 2021
Closed
@nickrandolph
Copy link
Contributor

@thomassth these changes look fine but can we link to the relevant issue here - I'm not sure what exactly we're fixing

@thomassth
Copy link
Contributor Author

I was looking at this comment.

The whole thread was repeatedly referenced in out issues and readme.

Not sure what it fixes, as I didn't see any error on my side before, but it seems needed.

@nickrandolph
Copy link
Contributor

@andzejsw and @thomassth are you ok with this PR?

@andzejsw
Copy link
Contributor

andzejsw commented Jul 7, 2021

All looks good to me

@thomassth thomassth requested a review from nickrandolph July 28, 2021 18:30
@thomassth thomassth requested a review from andzejsw September 18, 2021 10:56
@thomassth thomassth mentioned this pull request Oct 29, 2021
Closed
sowens-csd
sowens-csd approved these changes Nov 3, 2021
View reviewed changes
Copy link
Contributor

@sowens-csd sowens-csd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look safe to me. Ran successfully on both an iOS 15 simulator and a real device.

@thomassth thomassth merged commit 55b4561 into builttoroam:develop Nov 3, 2021
@thomassth thomassth deleted the wip branch November 23, 2021 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sowens-csd sowens-csd sowens-csd approved these changes

@nickrandolph nickrandolph Awaiting requested review from nickrandolph

@andzejsw andzejsw Awaiting requested review from andzejsw

@builttoroamadmin builttoroamadmin Awaiting requested review from builttoroamadmin

@builttoroamteam builttoroamteam Awaiting requested review from builttoroamteam

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@thomassth @nickrandolph @andzejsw @sowens-csd