Add pack remove-registry command
#877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elbandito
force-pushed
the
remove_registry
branch
from
7e57e71 to
51e843a
Compare
Codecov Report
@@ Coverage Diff @@
## main #877 +/- ##
==========================================
+ Coverage 76.15% 76.30% +0.16%
==========================================
Files 87 88 +1
Lines 4464 4493 +29
==========================================
+ Hits 3399 3428 +29
Misses 710 710
Partials 355 355
Flags with carried forward coverage won't be shown. Click here to find out more. |
jromero
suggested changes
Oct 5, 2020
elbandito
force-pushed
the
remove_registry
branch
6 times, most recently
from
f9009ee to
b2a5386
Compare
dfreilich
reviewed
Oct 12, 2020
internal/commands/remove_registry.go
Outdated
| } | ||
| config.Write(cfg, cfgPath) | ||
|
|
||
| logger.Infof("Successfully removed %s to from registries", style.Symbol(registryName)) |
There was a problem hiding this comment.
Suggested change
| logger.Infof("Successfully removed %s to from registries", style.Symbol(registryName)) | |
| logger.Infof("Successfully removed %s from registries", style.Symbol(registryName)) |
internal/commands/remove_registry.go
Outdated
| return nil | ||
| }), | ||
| } | ||
| cmd.Example = "pack remove-registry myregistry" |
There was a problem hiding this comment.
nit: Move to the definition of the cobra.Command
Comment on lines
+24
to
+28
| if registryName == config.OfficialRegistryName { | ||
| return errors.Errorf("%s is a reserved registry name, please provide a different registry", | ||
| style.Symbol(config.OfficialRegistryName)) | ||
| } |
There was a problem hiding this comment.
Are we sure this is the desired behavior? Users could want to remove it for security/compliance purposes, for instance
There was a problem hiding this comment.
The desired behavior is to always provide a functioning default registry by default, which is why we have this in place. For the question on security/compliance, I'm not concerned at this point. I'd rather get some customer feedback before making too many assumptions.
Signed-off-by: Travis <longoria.public@gmail.com>
elbandito
force-pushed
the
remove_registry
branch
from
b2a5386 to
e22e666
Compare
jromero
approved these changes
Oct 20, 2020
jromero
added
experimental
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR provides a new
packcommand for removing registries viapack remove-registryOutput
New
Documentation
Related
Resolves #745