Besides the failing linter these changes look good to me. Awesome that this is now tested :)

@zmackie any follow up on this?

@jromero Should be ready to go. lint fixed.

@zmackie seems to still be failing :/

You can try running make prepare-for-pr locally.

Codecov Report

Merging #602 into master will increase coverage by 0.17%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #602      +/-   ##
==========================================
+ Coverage   70.59%   70.77%   +0.17%     
==========================================
  Files          66       66              
  Lines        3710     3712       +2     
==========================================
+ Hits         2619     2627       +8     
+ Misses        757      752       -5     
+ Partials      334      333       -1     

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87030a1...d2ea3b5. Read the comment docs.

@zmackie seems to still be failing :/

You can try running make prepare-for-pr locally.

Should be GTG according to make prepare-for-pr (although I think that make command is not working properly see:

-----------------
NOTICE: There are some files that have not been committed.
-----------------

On branch fix/default-proc-publish
Your branch is up to date with 'origin/fix/default-proc-publish'.

nothing to commit, working tree clean

-----------------
NOTICE: There are some files that have not been committed.
-----------------