Overwrite permissions of zip files for FAT jars #598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…issions (e.g. FAT jars) Signed-off-by: David Freilich <dfreilich@vmware.com>
Signed-off-by: David Freilich <dfreilich@vmware.com>
Codecov Report
@@ Coverage Diff @@
## master #598 +/- ##
==========================================
+ Coverage 70.14% 70.44% +0.30%
==========================================
Files 64 64
Lines 3684 3695 +11
==========================================
+ Hits 2584 2603 +19
+ Misses 770 762 -8
Partials 330 330
Continue to review full report at Codecov.
|
zmackie
previously requested changes
Apr 30, 2020
Signed-off-by: David Freilich <dfreilich@vmware.com>
jromero
reviewed
Apr 30, 2020
* Remove Focus on test Signed-off-by: David Freilich <dfreilich@vmware.com>
Signed-off-by: David Freilich <dfreilich@vmware.com>
* Allows for possibility of file not being stored as FAT, and therefore not overwriting permissions Signed-off-by: David Freilich <dfreilich@vmware.com>
Signed-off-by: David Freilich <dfreilich@vmware.com>
jromero
approved these changes
May 5, 2020
jromero
added
the
type/enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some older methods of DOS compression don't contain proper permissions (e.g.
FATformatted jars, vsunix), and deny buildpacks access to their files. This PR identifies FAT files based on the first byte of theirheader.CreaterVersion, as done in thezipsource (https://golang.org/src/archive/zip/struct.go).Closes #464
Signed-off-by: David Freilich dfreilich@vmware.com