Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve contribution process #224

Merged
merged 1 commit into from
Jul 3, 2019
Merged

Improve contribution process #224

merged 1 commit into from
Jul 3, 2019

Conversation

jromero
Copy link
Member

@jromero jromero commented Jun 26, 2019

  • Add CONTRIBUTING.md with setup and process instructions
  • Distinguish between verification of format and actual formatting
  • Use Makefile for osx on travis

Signed-off-by: Javier Romero jromero@pivotal.io

@jromero jromero force-pushed the contrib-improvements branch 2 times, most recently from d407343 to c86e816 Compare June 26, 2019 03:47
Makefile Show resolved Hide resolved
@jromero jromero requested review from ekcasey and sclevine June 26, 2019 15:03
Copy link
Member

@ekcasey ekcasey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@jromero jromero force-pushed the contrib-improvements branch from c86e816 to e2dbf63 Compare July 3, 2019 15:33
- Add CONTRIBUTING.md with setup and process instructions
- Distinguish between verification of format and actual formatting
- Use Makefile for osx on travis

Signed-off-by: Javier Romero <jromero@pivotal.io>
@jromero jromero force-pushed the contrib-improvements branch from e2dbf63 to f2694c5 Compare July 3, 2019 15:35
@ekcasey ekcasey merged commit a826061 into master Jul 3, 2019
@ekcasey ekcasey deleted the contrib-improvements branch October 29, 2019 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants