Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removes acceptance test dependency on samples builder #154

Merged
merged 2 commits into from
Apr 9, 2019

Conversation

ekcasey
Copy link
Member

@ekcasey ekcasey commented Apr 9, 2019

  • tests create a builder for use in build tests
  • this means acceptance tests won't run on windows until we fix
    create-builder on windows

Signed-off-by: Emily Casey ecasey@pivotal.io
Signed-off-by: Andrew Meyer ameyer@pivotal.io

ekcasey and others added 2 commits April 9, 2019 09:26
* tests create a builder for use in build tests
* this means acceptance tests won't run on windows until we fix
create-builder on windows

Signed-off-by: Emily Casey <ecasey@pivotal.io>
Signed-off-by: Andrew Meyer <ameyer@pivotal.io>
* choose a name for the test stack that is less likely to conflict with other images
* removes unnescessary print statement in mock_app

Signed-off-by: Danny Joyce <djoyce@pivotal.io>
Signed-off-by: Emily Casey <ecasey@pivotal.io>
@ekcasey ekcasey merged commit 52adbf3 into master Apr 9, 2019
@ekcasey ekcasey deleted the remove-dependency-on-samples branch April 9, 2019 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant